[#1982] Add file-type error validation for document-upload #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #978 +/- ##
========================================
Coverage 94.74% 94.74%
========================================
Files 872 872
Lines 30571 30571
========================================
Hits 28965 28965
Misses 1606 1606 ☔ View full report in Codecov by Sentry. |
jiromaykin
force-pushed
the
feature/1982-error-validation-document-type-upload
branch
3 times, most recently
from
b9a9040 to
52bd213
Compare
stevenbal
requested changes
Feb 5, 2024
src/open_inwoner/components/templates/components/Form/FileInput.html
Outdated
Show resolved
Hide resolved
|
Looks good overall, few minor remarks |
jiromaykin
force-pushed
the
feature/1982-error-validation-document-type-upload
branch
2 times, most recently
from
b38f749 to
1d41034
Compare
jiromaykin
force-pushed
the
feature/1982-error-validation-document-type-upload
branch
from
d06884c to
8027356
Compare
stevenbal
approved these changes
Feb 8, 2024
src/open_inwoner/components/templates/components/Card/CardContainer.html
Show resolved
Hide resolved
pi-sigma
approved these changes
Feb 8, 2024
jiromaykin
changed the title
stevenbal
deleted the
feature/1982-error-validation-document-type-upload
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: https://taiga.maykinmedia.nl/project/open-inwoner/task/1982
Plus: also fixed the issue where the delete button became non-functional when more than 1 faulty file is selected.