-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#2059] Add emailnotification templates #999
[#2059] Add emailnotification templates #999
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #999 +/- ##
===========================================
+ Coverage 94.74% 94.79% +0.05%
===========================================
Files 872 873 +1
Lines 30546 30578 +32
===========================================
+ Hits 28940 28987 +47
+ Misses 1606 1591 -15 ☔ View full report in Codecov by Sentry. |
9ddbbfa
to
69b958d
Compare
@pi-sigma @Bartvaderkin see thursday if you can help Jiro out with getting his new mail templates workable for case notifications. I've showed him the _base.html from mail-editor (https://github.com/maykinmedia/mail-editor/tree/master/mail_editor/templates/mail ) explained |
6698209
to
77f0b50
Compare
2367329
to
5d19724
Compare
a047754
to
c135871
Compare
FAIL: test_send_case_update_email (open_inwoner.openzaak.tests.test_notification_utils.NotificationHandlerUtilsTestCase.test_send_case_update_email)Traceback (most recent call last): |
c135871
to
0f61b9c
Compare
[#2059] Needed rebasing to updated branch #999
68f026f
to
c752e7b
Compare
…L_EDITOR_BASE_HOST setting
…tatus notification
b4114be
to
f3dd3e2
Compare
Can be reviewed after Bart's rebase tests pass |
I don't know what is going on with the webkit e2e test, I see it failing elsewhere too. |
Feels premature, but merging this in because of the release |
issue: https://taiga.maykinmedia.nl/project/open-inwoner/task/2059
Figma designs: https://www.figma.com/file/iKGhWhstaLIlFSaND2q7cE/OIP---Designs-(new)?type=design&node-id=1080-7543&mode=design&t=6F5ky4GxXhMxiWJ8-0
How to preview e-mail templates:
go to http://localhost:8000/admin/mail_editor/mailtemplate/
delete all templates (checkboxes/dropdown)
in terminal: $
python src/manage.py add_missing_templates
reload admin page, click "open" to see processed preview, which also contains a field in which you can send yourself a test e-mail (locally: only possible if you have an App Password added to your Gmail Security configurations with 2-factor!)
might need 'previous case status' def.
Fallbacks may need to be created for border-radius (all Microsoft mail clients unsupported).
Fonts can only be loaded as font-face CDN hosted fonts - is not supported in many email-clients so added fallbacks for commonly used local fonts.
In short: it's going to look quite different in all email-clients and different machines.