Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2059] Add emailnotification templates #999

Merged
merged 19 commits into from
Feb 14, 2024

Conversation

jiromaykin
Copy link
Contributor

@jiromaykin jiromaykin commented Jan 30, 2024

issue: https://taiga.maykinmedia.nl/project/open-inwoner/task/2059
Figma designs: https://www.figma.com/file/iKGhWhstaLIlFSaND2q7cE/OIP---Designs-(new)?type=design&node-id=1080-7543&mode=design&t=6F5ky4GxXhMxiWJ8-0

How to preview e-mail templates:

  • go to http://localhost:8000/admin/mail_editor/mailtemplate/

  • delete all templates (checkboxes/dropdown)

  • in terminal: $ python src/manage.py add_missing_templates

  • reload admin page, click "open" to see processed preview, which also contains a field in which you can send yourself a test e-mail (locally: only possible if you have an App Password added to your Gmail Security configurations with 2-factor!)

  • might need 'previous case status' def.

Fallbacks may need to be created for border-radius (all Microsoft mail clients unsupported).
Fonts can only be loaded as font-face CDN hosted fonts - is not supported in many email-clients so added fallbacks for commonly used local fonts.

In short: it's going to look quite different in all email-clients and different machines.

@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (79332e4) 94.74% compared to head (cb0008c) 94.79%.
Report is 9 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #999      +/-   ##
===========================================
+ Coverage    94.74%   94.79%   +0.05%     
===========================================
  Files          872      873       +1     
  Lines        30546    30578      +32     
===========================================
+ Hits         28940    28987      +47     
+ Misses        1606     1591      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jiromaykin jiromaykin force-pushed the feature/2059-add-email-design-templates-cases branch 2 times, most recently from 9ddbbfa to 69b958d Compare January 30, 2024 16:39
@alextreme
Copy link
Member

@pi-sigma @Bartvaderkin see thursday if you can help Jiro out with getting his new mail templates workable for case notifications.

I've showed him the _base.html from mail-editor (https://github.com/maykinmedia/mail-editor/tree/master/mail_editor/templates/mail ) explained add_missing_templates and we tried out zgw_dev_status however this requires a few more steps before Jiro has a way to try out and improve his mail templates

@jiromaykin jiromaykin force-pushed the feature/2059-add-email-design-templates-cases branch from 6698209 to 77f0b50 Compare January 30, 2024 20:09
@jiromaykin jiromaykin force-pushed the feature/2059-add-email-design-templates-cases branch 7 times, most recently from 2367329 to 5d19724 Compare February 6, 2024 13:48
@jiromaykin jiromaykin added the wip Work in progress label Feb 6, 2024
@jiromaykin jiromaykin force-pushed the feature/2059-add-email-design-templates-cases branch from a047754 to c135871 Compare February 8, 2024 16:48
@alextreme
Copy link
Member

FAIL: test_send_case_update_email (open_inwoner.openzaak.tests.test_notification_utils.NotificationHandlerUtilsTestCase.test_send_case_update_email)

Traceback (most recent call last):
File "/home/runner/work/open-inwoner/open-inwoner/src/open_inwoner/openzaak/tests/test_notification_utils.py", line 57, in test_send_case_update_email
self.assertIn(case_url, body_html)
AssertionError: '/cases/aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa/status/' not found in

@jiromaykin jiromaykin force-pushed the feature/2059-add-email-design-templates-cases branch from c135871 to 0f61b9c Compare February 12, 2024 09:44
jiromaykin added a commit that referenced this pull request Feb 12, 2024
[#2059] Needed rebasing to updated branch #999
@jiromaykin jiromaykin force-pushed the feature/2059-add-email-design-templates-cases branch from 68f026f to c752e7b Compare February 13, 2024 15:39
@alextreme alextreme marked this pull request as ready for review February 14, 2024 11:55
@alextreme alextreme requested a review from pi-sigma February 14, 2024 11:55
@alextreme alextreme requested a review from stevenbal February 14, 2024 11:55
@Bartvaderkin Bartvaderkin force-pushed the feature/2059-add-email-design-templates-cases branch from b4114be to f3dd3e2 Compare February 14, 2024 11:56
@alextreme
Copy link
Member

Can be reviewed after Bart's rebase tests pass

@Bartvaderkin
Copy link
Contributor

I don't know what is going on with the webkit e2e test, I see it failing elsewhere too.

@alextreme
Copy link
Member

Feels premature, but merging this in because of the release

@alextreme alextreme merged commit b4d6777 into develop Feb 14, 2024
13 of 16 checks passed
@alextreme alextreme deleted the feature/2059-add-email-design-templates-cases branch February 14, 2024 15:20
@pi-sigma pi-sigma mentioned this pull request Feb 14, 2024
5 tasks
@jiromaykin jiromaykin removed the wip Work in progress label Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants