Feature/233 fix values partij identificatoren #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielmursa-dev
force-pushed
the
feature/233-fix-values-partij-identificatoren
branch
5 times, most recently
from
c90b055 to
d395b24
Compare
danielmursa-dev
force-pushed
the
feature/233-fix-values-partij-identificatoren
branch
from
d395b24 to
8a83b40
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #291 +/- ##
==========================================
+ Coverage 97.10% 97.21% +0.11%
==========================================
Files 177 180 +3
Lines 8656 8998 +342
==========================================
+ Hits 8405 8747 +342
Misses 251 251 ☔ View full report in Codecov by Sentry. |
danielmursa-dev
force-pushed
the
feature/233-fix-values-partij-identificatoren
branch
from
d8e8384 to
28bf95d
Compare
[#233] Fix tests [#233] Install django-digid-eherkenning [#233] Fix tests [#233] Improve Validator [#233] Fix tests [#233] Isort and Flake8 [#233] Improvements [#233] Remove django-digid-eherkenning [#233] Fix requirements [#233] Fix requirements 2 [#233] Fix tests [#233] Flake8 [#233] Fix validation errors [#233] Update class [#233] Remove unused import
danielmursa-dev
force-pushed
the
feature/233-fix-values-partij-identificatoren
branch
from
3a04c9d to
634a0f3
Compare
stevenbal
requested changes
Dec 24, 2024
swrichards
requested changes
Jan 6, 2025
src/openklant/components/klantinteracties/tests/test_validators.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #233
In this PR I have updated the fields so that they can be ChoiceFields:
partij_identificator_code_registerpartij_identificator_code_objecttypepartij_identificator_code_soort_object_idIn addition to validating the fields, I created a validator so that the values chosen by the user follow rules/hierarchies, as written in this comment: #233 (comment)
In particular, each choice must be part of the group admitted by the superior choice.
If the superior choice is
overige, the rule no longer applies.PartijIdentificatorCodeRegister->PartijIdentificatorCodeObjectType->PartijIdentificatorCodeSoortObjectIdIn commonground-api-common I created a new Validator for ObjectId: this is the PR
maykinmedia/commonground-api-common#58
PS:
I ask for a special check on Dutch translations