-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔧 [open-zaak/open-zaak#1629] Refactor settings module #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenbal
force-pushed
the
feature/refactor-settings
branch
4 times, most recently
from
May 21, 2024 12:40
d72f4f6
to
94c5b2c
Compare
stevenbal
changed the title
Feature/refactor settings
🔧 [open-zaak/open-zaak#1629] Refactor settings module
May 21, 2024
stevenbal
force-pushed
the
feature/refactor-settings
branch
from
May 21, 2024 14:58
94c5b2c
to
c260e9a
Compare
stevenbal
force-pushed
the
feature/refactor-settings
branch
from
June 6, 2024 07:49
c260e9a
to
d04a2bd
Compare
use base settings from open-api-framework and modify production settings to support subpath
stevenbal
force-pushed
the
feature/refactor-settings
branch
from
June 6, 2024 07:58
d04a2bd
to
c05f223
Compare
9 tasks
stevenbal
force-pushed
the
feature/refactor-settings
branch
from
June 6, 2024 09:43
20e70eb
to
26b8181
Compare
stevenbal
force-pushed
the
feature/refactor-settings
branch
from
June 6, 2024 09:44
26b8181
to
c46a53f
Compare
Coperh
reviewed
Jun 7, 2024
annashamray
approved these changes
Jun 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I'll add also Bart as main Open Klant developer to double check
stevenbal
force-pushed
the
feature/refactor-settings
branch
from
June 20, 2024 07:57
21c4845
to
b545b5e
Compare
@bart-maykin could you do a double check so we can get this merged? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partially fixes open-zaak/open-zaak#1629
Changes