Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all changed files staged and committed #218

Closed
SRFU-NN opened this issue Aug 7, 2023 · 8 comments
Closed

Not all changed files staged and committed #218

SRFU-NN opened this issue Aug 7, 2023 · 8 comments

Comments

@SRFU-NN
Copy link

SRFU-NN commented Aug 7, 2023

I have an issue where bumpver doesn't stage and commit all of the changes it has made. As best I can tell, it fails when there is capital letters in a folder name on the path to a file.

Reproduction steps:

  1. Fetch https://github.com/SRFU-NN/test_bumpver/tree/main/src (minimal example)
  2. Create a virtual environment
  3. Install bumpver version 2023.1125
  4. Run bumpver update --patch

Expected results:
All 4 copies of test.txt have updated version, and are included in the tagged commit.

Actual result:
Three copies of test.txt has updated version and are included in the tagged commit.
src\CaPiTaLiZaTiOn\test.txt has updated version, but is not staged.

Environment:
Windows 10 Enterprise, Version 10.0.19044 Build 19044
Python 3.9.4
bumpver version 2023.1125

@mbarkhau
Copy link
Owner

mbarkhau commented Aug 7, 2023

Thank you for this report. I imagine this is a duplicate of #204.

@SRFU-NN
Copy link
Author

SRFU-NN commented Aug 8, 2023

It seems very similar. I suppose this issue should just be closed, then?

@mbarkhau
Copy link
Owner

mbarkhau commented Aug 8, 2023

Yes, I've closed it. If you can help to figure out how to fix this, I'd greatly appreciate it.

@mbarkhau mbarkhau closed this as completed Aug 8, 2023
@SRFU-NN
Copy link
Author

SRFU-NN commented Aug 8, 2023 via email

@SRFU-NN
Copy link
Author

SRFU-NN commented Aug 8, 2023 via email

@SRFU-NN
Copy link
Author

SRFU-NN commented Aug 8, 2023

I have created an issue in pathlib2: jazzband/pathlib2#86

@mbarkhau
Copy link
Owner

mbarkhau commented Aug 8, 2023

@SRFU-NN I'd like to somehow test the changes in PR #219. Since we don't have windows in our CI system, perhaps you can help with this? Can you review PR #219 ?

@SRFU-NN
Copy link
Author

SRFU-NN commented Aug 9, 2023

@SRFU-NN I'd like to somehow test the changes in PR #219. Since we don't have windows in our CI system, perhaps you can help with this? Can you review PR #219 ?

I'll look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants