whitespace pattern proof of concept #228
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds basic support for whitespace patterns by altering how regex's are compiled, no longer escaping
+
and*
symbols.To handle this when rewriting lines, a
replacement_pattern
is added toPattern
, allowing a pre-formatted version string to be subbed into the matching line directly. This means no changes are made to_format_segment
.A couple of tests are added to show it working, and
test_v1_error_bad_pattern
breaks... but I have no idea why because I didn't touch v1 pattern code.