Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mps-cli-gradle-plugin: Empty list of models when no models dir #12

Merged
merged 3 commits into from
Jul 30, 2023
Merged

mps-cli-gradle-plugin: Empty list of models when no models dir #12

merged 3 commits into from
Jul 30, 2023

Conversation

kolmar
Copy link
Collaborator

@kolmar kolmar commented Jul 28, 2023

Fixed buildModel task failing when some solution didn't have models directory.

danielratiu
danielratiu approved these changes Jul 30, 2023
View reviewed changes
Copy link
Member

@danielratiu danielratiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - I have also increased the timeout for the git command from 5s to 60s and added an additional check that the process ended successfully

@danielratiu danielratiu merged commit f30af5b into main Jul 30, 2023
4 checks passed
@kolmar kolmar deleted the fix/build_module_without_models_dir branch July 30, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielratiu danielratiu danielratiu approved these changes

@baran-goru baran-goru Awaiting requested review from baran-goru

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kolmar @danielratiu @ratiud