meta/Extracted common code to build module repository #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolmar
changed the title
wjglerum
approved these changes
Aug 29, 2023
| SLanguageBuilder.clear() | ||
| sourcesDir.each { | ||
| def dir = Paths.get(it).toAbsolutePath().normalize().toString() | ||
| println("loading models from directory: " + dir) |
There was a problem hiding this comment.
would it make sense to move this to a logger too? 🤔
There was a problem hiding this comment.
mps-cli prints a lot of logs with println. This already used println before the change. It's those timings in particular, that took a lot of space, but didn't have much useful information
There was a problem hiding this comment.
alright makes sense, thanks for the info!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.