Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/minor improvments for python cli #29

Merged
merged 3 commits into from
Apr 10, 2024

Conversation

MLanghammer
Copy link
Collaborator

@MLanghammer MLanghammer commented Apr 7, 2024

two minor improvements for python-cli:

  • adds two caches for get_node_by_uuid and get_model_by_uuid to speed up resolving node references
  • get_property in SNode returns None if the property is not found

…property is not found instead of throwing an exception
…and get_node_by_uuid to speed up the functions if there are called multiple times for big repos
Copy link
Member

@danielratiu danielratiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a mini renaming - lgtm now

@danielratiu danielratiu merged commit 7150c71 into main Apr 10, 2024
2 of 3 checks passed
@danielratiu danielratiu deleted the feature/minor-improvments-for-python-cli branch April 10, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants