feat!: ActiveRecord 7.2 support #1132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored several modules to extend ActiveSupport::Concern, replacing the previous pattern using self.included with class_methods blocks
feat: add zeitwerk loader by default refactor: extracted the caching mechanism into it own concern
Updated instance variable checks and refactored taggable class attribute setup for better compatibility with modern Ruby versions. Removed version-specific logic now that support for Ruby versions below 1.9 is unnecessary.
jcoyne
added a commit
to projectblacklight/spotlight
that referenced
this pull request
Aug 22, 2024
jcoyne
added a commit
to projectblacklight/spotlight
that referenced
this pull request
Aug 22, 2024
jcoyne
added a commit
to projectblacklight/spotlight
that referenced
this pull request
Aug 22, 2024
jcoyne
added a commit
to projectblacklight/spotlight
that referenced
this pull request
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR remove support for EOL rubies and Rails.
closes: #1131
fixes: #1114 #1130
I will release the major version once the tests are green.