Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Has-proper-part and has-part usage Dron not compatible with RO #3

Open
matentzn opened this issue Apr 7, 2021 · 5 comments
Open

Has-proper-part and has-part usage Dron not compatible with RO #3

matentzn opened this issue Apr 7, 2021 · 5 comments

Comments

@matentzn
Copy link
Collaborator

matentzn commented Apr 7, 2021

To get DrOn to be fully compatible with RO, you should consider to migrate the following two relations:

Declaration(ObjectProperty(<http://www.obofoundry.org/ro/ro.owl#has_part>))
Declaration(ObjectProperty(<http://www.obofoundry.org/ro/ro.owl#has_proper_part>))

To their proper RO counterparts.

Originally, I thought that this needed changes to the DrOn builder pipeline:

dron/DrOn builder source code/dron-builder/src/main/scala/edu/uams/dbmi/redo/builder/DrOnBuilder.scala

but with a bit of luck, the DrOnBuilder.scala is generic enough to handle changes to DrOn as long as the rdfs:label has_proper_part is preserved:

image

Not 100% positive though, would need someone testing it.

@sjbost
Copy link

sjbost commented Dec 16, 2021

Team is investigating the source code.

@sjbost
Copy link

sjbost commented Nov 17, 2022

@dillerm and @hoganwr will look at Scala code in BitBucket repo. @LightGrenadier will check on access with Erik Schmidt for the previous people.

Looks like the lookup of the object property IRI by its rdfs:label is calling the SQL database.

@matentzn
Copy link
Collaborator Author

Note, this is now an easy fix @hoganwr as only the declarations remain - they can just be deleted.

@hoganwr
Copy link
Collaborator

hoganwr commented Dec 20, 2024 via email

@hoganwr
Copy link
Collaborator

hoganwr commented Dec 22, 2024

Actually, when you build the components, dron-ingredient.owl still uses it extensively. I think this is as simple as replacing it with the proper RO object property in the build scripts that create the three component OWL files. But it needs to be done and tested. Will work on this ASAP, but am currently working on the PATO import.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants