Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live chats + prospector fix #87

Merged
merged 10 commits into from
Sep 18, 2021
Merged

Live chats + prospector fix #87

merged 10 commits into from
Sep 18, 2021

Conversation

mdabrowski1990
Copy link
Owner

Description

Add link to discord server in contact sections of the documentation.
Change prospector version to enable static code analysis.

How Has This Been Tested?

  • actions executed

Process

I know the process and did my best to follow it

I have updated all places with discord channel invitation link.
Fix issue of prospector that cannot be installed.
@mdabrowski1990 mdabrowski1990 added bug Something isn't working documentation Improvements or additions to documentation labels Sep 11, 2021
@mdabrowski1990 mdabrowski1990 self-assigned this Sep 11, 2021
@coveralls
Copy link

coveralls commented Sep 11, 2021

Pull Request Test Coverage Report for Build 515

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 470: 0.0%
Covered Lines: 350
Relevant Lines: 350

💛 - Coveralls

This was linked to issues Sep 11, 2021
Use the opportunity to improve readability in README file.
Fix the grammar
Fixing issues that I have found during self-review.
Rephrase sponsoring part.
Copy link
Owner Author

@mdabrowski1990 mdabrowski1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expect these changes to be fixed before a merge.

SECURITY.md Outdated Show resolved Hide resolved
docs/source/pages/contribution.rst Outdated Show resolved Hide resolved
docs/source/pages/contribution.rst Outdated Show resolved Hide resolved
Fix the remarks.
Rephrase for better impression.
Another rephrasing.
Copy link
Owner Author

@mdabrowski1990 mdabrowski1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems nicer now :D

@mdabrowski1990 mdabrowski1990 merged commit d80c8dc into main Sep 18, 2021
@mdabrowski1990 mdabrowski1990 deleted the live_chats branch September 18, 2021 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prospector installation issue Live chats
2 participants