[ntuple] minor improvement in RDF DS

mdessole · Jul 1, 2024 · 4d94b5c · 4d94b5c
1 parent ac80c65
commit 4d94b5c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 8 deletions.
diff --git a/tree/dataframe/inc/ROOT/RNTupleDS.hxx b/tree/dataframe/inc/ROOT/RNTupleDS.hxx
@@ -131,8 +131,6 @@ public:
    std::vector<std::pair<ULong64_t, ULong64_t>> GetEntryRanges() final;
    std::string GetLabel() final { return "RNTupleDS"; }
 
-   bool SetEntry(unsigned int slot, ULong64_t entry) final;
-
    void Initialize() final;
    void InitSlot(unsigned int slot, ULong64_t firstEntry) final;
    void FinalizeSlot(unsigned int slot) final;
@@ -141,6 +139,9 @@ public:
    std::unique_ptr<ROOT::Detail::RDF::RColumnReaderBase>
    GetColumnReaders(unsigned int /*slot*/, std::string_view /*name*/, const std::type_info &) final;
 
+   // Old API, unused
+   bool SetEntry(unsigned int, ULong64_t) final { return true; }
+
 protected:
    Record_t GetColumnReadersImpl(std::string_view name, const std::type_info &) final;
 };

diff --git a/tree/dataframe/src/RNTupleDS.cxx b/tree/dataframe/src/RNTupleDS.cxx
@@ -454,12 +454,6 @@ RNTupleDS::GetColumnReaders(unsigned int slot, std::string_view name, const std:
    return reader;
 }
 
-bool RNTupleDS::SetEntry(unsigned int, ULong64_t)
-{
-   // Old API, unsused
-   return true;
-}
-
 void RNTupleDS::PrepareNextRanges()
 {
    assert(fNextRanges.empty());