Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: fixes for M1 speculative execution #97

Open
wants to merge 1 commit into
base: boost_overflows
Choose a base branch
from

Conversation

mckib2
Copy link

@mckib2 mckib2 commented Feb 5, 2023

Reference issue

What does this implement/fix?

Additional information

@mckib2
Copy link
Author

mckib2 commented Feb 5, 2023

@mdhaber This resolves all errors on this branch locally on the M1 Mac Mini. Still waiting to hear back from upstream if they can reproduce the issues/want to accept theses

The evidence seems to suggest that M1 speculative execution is failing to suppress failed branch exceptions in these cases. So the fixes are to try to dance around what we think the speculative execution is going to run into. Not sure if these issues are present in the latest firmware/updates for MacOS, so I'm delaying updating the Mac Mini

@mdhaber
Copy link
Owner

mdhaber commented Feb 5, 2023

Ooh, let me make sure I understand correctly:

The evidence seems to suggest that M1 speculative execution is failing to suppress failed branch exceptions in these cases.

Does this mean that it is supposed to be suppressing them but doesn't, and that an update to the firmware might fix that?

This suggests to me that the warnings are indeed harmless, if they are meant to be suppressed?

@mckib2
Copy link
Author

mckib2 commented Feb 5, 2023

Does this mean that it is supposed to be suppressing them but doesn't, and that an update to the firmware might fix that?

It could be firmware or just an OS upgrade. The SciPy job is using a 9 month old image, so we might try bumping that to see if it helps

This suggests to me that the warnings are indeed harmless, if they are meant to be suppressed?

Yes, they are harmless, just annoying. Failed branches can catastrophically fail and the user shouldn't see any indication

@mckib2
Copy link
Author

mckib2 commented Feb 5, 2023

This line could be changed to point to the latest image -- are you able to run that pipeline from your SciPy fork or this testing that must be done in the main repo?

@mdhaber
Copy link
Owner

mdhaber commented Feb 5, 2023

Go ahead and test in the main repo. It's worth it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants