Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make num visits include current visit #148

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Conversation

hamishwillee
Copy link
Collaborator

@hamishwillee hamishwillee commented Aug 13, 2024

Make session count for number of visits that is displayed match what is stored, and also mean "number of time visited including this one" rather than "number of times previously"

Demo-code fix to associated with mdn/content#35423

@github-actions github-actions bot added the idle Issues and pull requests with no activity for three months. label Sep 12, 2024
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Hamish 👍🏻

@bsmth bsmth merged commit 46ccd76 into main Oct 29, 2024
4 checks passed
@bsmth bsmth deleted the num_visits_includes_current branch October 29, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idle Issues and pull requests with no activity for three months.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants