Improve navigator.share example #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Better error handling, was failing silently when not supported. New version is similar to code example at https://developer.mozilla.org/en-US/docs/Web/API/Navigator/canShare#examples
pepelsbey
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better error handling, was failing silently when not supported.
New version is similar to code example at https://developer.mozilla.org/en-US/docs/Web/API/Navigator/canShare#examples
This example is linked to from:
(and possibly more, I didn't bother searching) and hosted at https://mdn.github.io/dom-examples/web-share/
If this PR is accepted, I'll open another that applies the same changes to the "live example" shown at https://developer.mozilla.org/en-US/docs/Web/API/Navigator/share#examples