Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clearing fade-in animation eventListeners #87

Merged
merged 2 commits into from
Jul 17, 2024
Merged

clearing fade-in animation eventListeners #87

merged 2 commits into from
Jul 17, 2024

Conversation

ordinaryperson420
Copy link
Contributor

There is an EventListeners that keep being added every time when fade-in animation plays. Their only purpose is to remove a className that triggers element animation via css. And they were never removed. I considered adding { once: true } to prevent this.

@bsmth bsmth requested a review from a team as a code owner July 17, 2024 09:44
@bsmth bsmth requested review from bsmth and removed request for a team July 17, 2024 09:44
bsmth
bsmth approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super, thank you!

@bsmth bsmth merged commit 8dd8e89 into mdn:main Jul 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsmth bsmth bsmth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ordinaryperson420 @bsmth