Fish feature install completes successfully even if fish install fails

[nikobockerman]

I built a dev container using the fish feature from this repository. However, once the container started up fish wasn't actually installed.

After some searching I finally found the logs from Docker Desktop about what had happened during the fish feature installation and the output is attached below.

It's evident that the feature reported successful installation even thought apt failed to install fish due to some likely transient error. In my opinion, the feature install should have failed and I could then have retried.
Now this unsuccessful feature install is cached by Docker as a layer and rebuilding ends up reusing that layer.

Would it perhaps be enough to use set -e in the install.sh script to avoid this?

Log output:

===========================================================================
Feature : fish
Description : Installs fish shell and Fisher plugin manager (optionally)
Id : ghcr.io/meaningful-ooo/devcontainer-features/fish
Version : 1.2.1
Documentation : https://github.com/meaningful-ooo/devcontainer-features/tree/main/src/fish
Options :
FISHER="false"
===========================================================================
Installing fish shell...
deb http://download.opensuse.org/repositories/shells:/fish:/release:/3/Debian_12/ /
Get:1 http://deb.debian.org/debian bookworm InRelease [151 kB]
Get:3 http://deb.debian.org/debian bookworm-updates InRelease [52.1 kB]
Get:4 http://deb.debian.org/debian-security bookworm-security InRelease [48.0 kB]
Get:5 http://download.opensuse.org/repositories/shells:/fish:/release:/3/Debian_12 InRelease [1556 B]
Get:2 https://apt.llvm.org/bookworm llvm-toolchain-bookworm-18 InRelease [6836 B]
Get:6 http://deb.debian.org/debian bookworm/main amd64 Packages [8787 kB]
Get:7 http://download.opensuse.org/repositories/shells:/fish:/release:/3/Debian_12 Packages [1843 B]
Get:8 https://apt.llvm.org/bookworm llvm-toolchain-bookworm-18/main amd64 Packages [20.6 kB]
Get:9 http://deb.debian.org/debian bookworm-updates/main amd64 Packages [12.7 kB]
Get:10 http://deb.debian.org/debian-security bookworm-security/main amd64 Packages [137 kB]
Fetched 9219 kB in 4s (2102 kB/s)
Reading package lists...
Reading package lists...
Building dependency tree...
Reading state information...
The following package was automatically installed and is no longer required:
liblldb-14
Use 'apt autoremove' to remove it.
Suggested packages:
xdg-utils
Recommended packages:
xsel
The following NEW packages will be installed:
fish
0 upgraded, 1 newly installed, 0 to remove and 0 not upgraded.
Need to get 2558 kB of archives.
After this operation, 18.4 MB of additional disk space will be used.
Ign:1 http://download.opensuse.org/repositories/shells:/fish:/release:/3/Debian_12 fish 3.7.0-1
Ign:1 http://download.opensuse.org/repositories/shells:/fish:/release:/3/Debian_12 fish 3.7.0-1
Ign:1 http://download.opensuse.org/repositories/shells:/fish:/release:/3/Debian_12 fish 3.7.0-1
Err:1 http://download.opensuse.org/repositories/shells:/fish:/release:/3/Debian_12 fish 3.7.0-1
500 Internal Server Error [IP: 195.135.223.226 80]
E: Failed to fetch http://download.opensuse.org/repositories/shells:/fish:/release:/3/Debian_12/amd64/fish_3.7.0-1_amd64.deb 500 Internal Server Error [IP: 195.135.223.226 80]
E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?
./install.sh: line 109: fish: command not found
Done!

[eitsupi]

Thanks for reporting this. I agree with that it needs set -e.
Could you make a PR for fix this?
(Note that this repository expects you to use emoji in your commit comments.)

[nikobockerman]

I can make a PR to fix this.