Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Enhanced LRC format (Part II) (Redux) #8

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Support Enhanced LRC format (Part II) (Redux) #8

wants to merge 6 commits into from

Conversation

Nafeij
Copy link

@Nafeij Nafeij commented Apr 20, 2023 •
edited
Loading

Enhanced LRC is an extension of Simple LRC Format developed for the A2 Media Player. This supports adding an optional timestamp for words, syllables, or otherwise parts of a line. It takes the format: <mm:ss.xx>.

Enhanced LRC support

  • Add additional interfaces.
  • Add EnhancedLrc component. Lines will have a property syllables.
  • Add additional storybook example: Enhanced Lrc.

Misc

  • Migrate to Storybook 7 / Webpack 5 / Node.js 18.

This should be backwards-compatible with previous versions.

Warning: This PR depends on Part I. Upon merging both, change the 'clrc' dep in package.json to point to the updated version and not the fork.

Nafeij added 5 commits April 20, 2023 13:34
@Nafeij
reinit
cbf02c1
@Nafeij
attempt migration
08e01b3
@Nafeij
- migrate to storybook7 / webpack5 / node18
794d194 
  - rewrote playground to
  workaround storybook-react not allowing
  render of multiple components in same story
@Nafeij
reinit
944dada
@Nafeij
done
c4e9ead
@Nafeij Nafeij mentioned this pull request Apr 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Nafeij