Merge pull request #2 from methylbro/fix-response-body-plain-text

fix #1 Content-Type: Json and responses content in plain text
mediapart · Oct 10, 2017 · 007a99e · 007a99e
2 parents d2914d2 + db4ed48
commit 007a99e
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/.DS_Store b/.DS_Store
diff --git a/src/Controller/LaPresseLibreController.php b/src/Controller/LaPresseLibreController.php
@@ -13,7 +13,6 @@
 
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
-use Symfony\Component\HttpFoundation\JsonResponse;
 use Symfony\Component\HttpKernel\Exception\HttpException;
 use Mediapart\Bundle\LaPresseLibreBundle\Handler;
 
@@ -44,10 +43,12 @@ public function __construct(Handler $handler)
      */
     public function executeAction(Request $request)
     {
-        $headers = $this->handler->getHttpResponseHeaders();
-
+        $headers = array_merge(
+            $this->handler->getHttpResponseHeaders(),
+            ['Content-Type' => 'application/json']
+        );
         try {
-            $response = new JsonResponse(
+            $response = new Response(
                 $this->handler->process($request),
                 Response::HTTP_OK,
                 $headers

diff --git a/tests/Unit/Controller/LaPresseLibreControllerTest.php b/tests/Unit/Controller/LaPresseLibreControllerTest.php
@@ -51,7 +51,7 @@ public function testSuccess()
         $response = $controller->executeAction($request);
 
         $this->assertEquals(Response::HTTP_OK, $response->getStatusCode());
-        $this->assertEquals($result, json_decode($response->getContent()));
+        $this->assertEquals($result, $response->getContent());
     }
 
     /**