-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update go, dependencies and tools #117
Conversation
clobrano
commented
Jan 25, 2024
- Update Go to version 1.21
- Update to k8s 29.1 and Openshift release-4.16 dependencies
- Update Dockerfile
- More dependency updates
- Update tools and update code and manifests
Signed-off-by: Carlo Lobrano <c.lobrano@gmail.com>
Signed-off-by: Carlo Lobrano <c.lobrano@gmail.com>
- CentOS 9 builder image - UBI 9 final image - New Go install method since the previous one is currently not working for version 1.21 Signed-off-by: Carlo Lobrano <c.lobrano@gmail.com>
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clobrano The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test 4.15-openshift-e2e |
# OPERATOR_SDK versions at github.com/operator-framework/operator-sdk/releases | ||
OPERATOR_SDK_VERSION ?= v1.30.0 | ||
# OPERATOR_SDK versions at https://github.com/operator-framework/operator-sdk/releases | ||
OPERATOR_SDK_VERSION ?= v1.32.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason for not using 1.33?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to go through the breaking changes after the release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are breaking changes? Didn't notice that... 🙈 😄 But ok of course, just wanted to be sure that it's on purpose
@@ -47,13 +47,13 @@ metadata: | |||
capabilities: Basic Install | |||
categories: OpenShift Optional | |||
containerImage: "" | |||
createdAt: "" | |||
createdAt: "2024-01-25T10:30:34Z" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was empty before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah damn
Signed-off-by: Carlo Lobrano <c.lobrano@gmail.com>
6e60b7b
to
a04d7e8
Compare
/test 4.15-openshift-e2e |
/lgtm |
Ignoring codacity remarks on vendor and merge |