Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go, dependencies and tools #117

Merged
merged 7 commits into from
Jan 25, 2024
Merged

Conversation

clobrano
Copy link
Contributor

  • Update Go to version 1.21
  • Update to k8s 29.1 and Openshift release-4.16 dependencies
  • Update Dockerfile
  • More dependency updates
  • Update tools and update code and manifests

Signed-off-by: Carlo Lobrano <c.lobrano@gmail.com>
Signed-off-by: Carlo Lobrano <c.lobrano@gmail.com>
- CentOS 9 builder image
- UBI 9 final image
- New Go install method since the previous one is currently not working
  for version 1.21

Signed-off-by: Carlo Lobrano <c.lobrano@gmail.com>
Copy link
Contributor

openshift-ci bot commented Jan 25, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Jan 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@clobrano
Copy link
Contributor Author

/test 4.15-openshift-e2e

# OPERATOR_SDK versions at github.com/operator-framework/operator-sdk/releases
OPERATOR_SDK_VERSION ?= v1.30.0
# OPERATOR_SDK versions at https://github.com/operator-framework/operator-sdk/releases
OPERATOR_SDK_VERSION ?= v1.32.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason for not using 1.33?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to go through the breaking changes after the release

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are breaking changes? Didn't notice that... 🙈 😄 But ok of course, just wanted to be sure that it's on purpose

@@ -47,13 +47,13 @@ metadata:
capabilities: Basic Install
categories: OpenShift Optional
containerImage: ""
createdAt: ""
createdAt: "2024-01-25T10:30:34Z"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was empty before?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah damn

Signed-off-by: Carlo Lobrano <c.lobrano@gmail.com>
@clobrano
Copy link
Contributor Author

/test 4.15-openshift-e2e

@slintes
Copy link
Member

slintes commented Jan 25, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 25, 2024
@slintes slintes mentioned this pull request Jan 25, 2024
@clobrano clobrano marked this pull request as ready for review January 25, 2024 18:48
@openshift-ci openshift-ci bot requested review from beekhof and razo7 January 25, 2024 18:48
@clobrano
Copy link
Contributor Author

Ignoring codacity remarks on vendor and merge

@clobrano clobrano merged commit f960216 into medik8s:main Jan 25, 2024
17 of 19 checks passed
@clobrano clobrano deleted the update-tools/1 branch January 30, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants