Use release tag for release automation #125
Conversation
Current PR bundle automation is using main branch, while it should use the tagged commit instead. Signed-off-by: Carlo Lobrano <c.lobrano@gmail.com>
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clobrano The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -55,6 +55,7 @@ jobs: | |||
| export VERSION=${VERSION} | |||
| export PREVIOUS_VERSION=${PREVIOUS_VERSION} | |||
| export SKIP_RANGE_LOWER=${SKIP_RANGE_LOWER} | |||
| git -C operator checkout v${VERSION} | |||
There was a problem hiding this comment.
Can it maybe done in the earlier step of Checkout code?
There was a problem hiding this comment.
It could but
- It needs another token (it can be the same used later)
- I wasn't able to make the
actions/checkoutrefparameter dynamic. It works if I write
- name: Checkout code
uses: actions/checkout@v3
with:
path: operator
ref: v0.3.0
fetch-depth: 0
but whatever other variable I tried for the tag name, it took it litteraly (e.g. ${VERSION}, ${{ inputs.version }}, etc.)
There was a problem hiding this comment.
Ok, then no need to further investigate that :D
There was a problem hiding this comment.
wait, you select the branch / tag in the action's UI, right? It doesn't checkout the selected ref then?
There was a problem hiding this comment.
I missed that selector, thanks!
At the moment I can't test, but let's keep this on hold since it might be unnecessary
|
/lgtm |
|
/retest
|
|
/hold |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Closing this as unnecessary. The right branch/tag can be selected via workflow UI |
Current PR bundle automation is using main branch, while it should use
the tagged commit instead.