Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use release tag for release automation #125

Closed
wants to merge 1 commit into from
Closed

Use release tag for release automation #125

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ jobs:
export VERSION=${VERSION}
export PREVIOUS_VERSION=${PREVIOUS_VERSION}
export SKIP_RANGE_LOWER=${SKIP_RANGE_LOWER}
git -C operator checkout v${VERSION}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can it maybe done in the earlier step of Checkout code?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could but

  1. It needs another token (it can be the same used later)
  2. I wasn't able to make the actions/checkout ref parameter dynamic. It works if I write
- name: Checkout code
  uses: actions/checkout@v3
  with:
      path: operator
      ref: v0.3.0
      fetch-depth: 0

but whatever other variable I tried for the tag name, it took it litteraly (e.g. ${VERSION}, ${{ inputs.version }}, etc.)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, then no need to further investigate that :D

Copy link
Member

@slintes slintes Feb 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait, you select the branch / tag in the action's UI, right? It doesn't checkout the selected ref then?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Contributor Author

@clobrano clobrano Feb 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed that selector, thanks!
At the moment I can't test, but let's keep this on hold since it might be unnecessary

image

rm -r operator/bundle && make -C operator bundle-community

- name: Copy bundle
Expand Down
Loading