Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to create a test bundle for development #126

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Allow to create a test bundle for development #126

merged 1 commit into from
Feb 19, 2024

Conversation

clobrano
Copy link
Contributor

@clobrano clobrano commented Feb 16, 2024 •
edited
Loading

Is currently not possible to create a test bundle (e.g. with changes or custom IMAGE_REGISTRY) due to docker-build target running verify-no-changes recipe

Let docker-build run only test-no-verify-changes to permit test bundles creation.

@clobrano
Allow to create a test bundle for development
95eb835 
Is currently not possible to create a test bundle (e.g. with changes or
custom IMAGE_REGISTRY) due to `docker-build` target running
`verify-no-changes` recipe

Let `docker-build` run only `test-no-verify-changes` to permit test
bundles creation.

Signed-off-by: Carlo Lobrano <c.lobrano@gmail.com>
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 16, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the lgtm label Feb 19, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano, slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@clobrano clobrano marked this pull request as ready for review February 19, 2024 08:28
@openshift-merge-bot openshift-merge-bot bot merged commit 9955b60 into medik8s:main Feb 19, 2024
19 checks passed
@clobrano
Copy link
Contributor Author

clobrano commented Mar 5, 2024

/cherry-pick release-0.3

@openshift-cherrypick-robot
Copy link

@clobrano: new pull request created: #130

In response to this:

/cherry-pick release-0.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slintes slintes slintes approved these changes

@mshitrit mshitrit Awaiting requested review from mshitrit

@razo7 razo7 Awaiting requested review from razo7

Assignees

@slintes slintes

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clobrano @openshift-cherrypick-robot @slintes