-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OCP annotation to OKD bundle #137
Add OCP annotation to OKD bundle #137
Conversation
Skipping CI for Draft Pull Request. |
/test 4.16-openshift-e2e |
Looks sane to me, do we understand all the annotations? |
Makefile
Outdated
@@ -329,9 +338,25 @@ verify-previous-version: ## Verifies that PREVIOUS_VERSION variable is set | |||
.PHONY: bundle-community-rh | |||
bundle-community-rh: bundle ## Update displayName field in the bundle's CSV | |||
sed -r -i "s|displayName: Machine Deletion Remediation operator.*|displayName: Machine Deletion Remediation Operator - Community Edition|;" ${CSV} | |||
$(MAKE) add-replaces-field |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't find this target?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doh, sorry, it's a leftover.
MDR only have 1 bundle (OKD) that needs the replaces field, so there's no need to specialize this part
we have ECOPROJECT-1972 to track the task, and there is a dedicated documentation page for the annotation |
OKD community pipeline is verifying the presence of OCP annotation. Signed-off-by: Carlo Lobrano <c.lobrano@gmail.com>
23b8222
to
5805c51
Compare
/test 4.16-openshift-e2e |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clobrano, slintes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-0.3 |
@clobrano: #137 failed to apply on top of branch "release-0.3":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Why we need this PR
OKD community pipeline is verifying the presence of OCP annotation.
Changes made
Add OCP annotation to OKD bundle
Which issue(s) this PR fixes
Test plan