Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.3] Fix verify-previous-version Makefile target #138

Conversation

clobrano
Copy link
Contributor

@clobrano clobrano commented Aug 7, 2024

manual cherry-pick #131

Signed-off-by: Carlo Lobrano <c.lobrano@gmail.com>
@openshift-ci openshift-ci bot requested review from mshitrit and razo7 August 7, 2024 15:59
Copy link
Contributor

openshift-ci bot commented Aug 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Aug 7, 2024
@clobrano
Copy link
Contributor Author

clobrano commented Aug 7, 2024

/retest

@clobrano
Copy link
Contributor Author

clobrano commented Aug 7, 2024

Timeout error 🤷

STEP: checking the Machine was deleted - /go/src/github.com/medik8s/machine-deletion-remediation/e2e/e2e_test.go:84 @ 08/07/24 16:50:27.597
[FAILED] Timed out after 300.009s.
Expected
      <bool>: false
  to be true 

@clobrano
Copy link
Contributor Author

clobrano commented Aug 7, 2024

/retest

1 similar comment
@clobrano
Copy link
Contributor Author

clobrano commented Aug 7, 2024

/retest

@clobrano
Copy link
Contributor Author

clobrano commented Aug 7, 2024

/lgtm

Copy link
Contributor

openshift-ci bot commented Aug 7, 2024

@clobrano: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@clobrano
Copy link
Contributor Author

clobrano commented Aug 7, 2024

oh sure, this is a manual cherry-pick 🤦

@razo7
Copy link
Member

razo7 commented Aug 8, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 8, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 36da585 into medik8s:release-0.3 Aug 8, 2024
27 checks passed
@clobrano clobrano deleted the release-0.3-fix-makefile-previous-version-0 branch August 8, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants