Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.3] Add OCP annotation to OKD bundle #142

Closed

Conversation

clobrano
Copy link
Contributor

@clobrano clobrano commented Aug 8, 2024

manual cherry-pick of #137

clobrano and others added 11 commits March 5, 2024 15:43
Is currently not possible to create a test bundle (e.g. with changes or
custom IMAGE_REGISTRY) due to `docker-build` target running
`verify-no-changes` recipe

Let `docker-build` run only `test-no-verify-changes` to permit test
bundles creation.

Signed-off-by: Carlo Lobrano <c.lobrano@gmail.com>
…-pick-126-to-release-0.3

[release-0.3] Allow to create a test bundle for development
Signed-off-by: Carlo Lobrano <c.lobrano@gmail.com>
…-previous-version-0

[release-0.3] Fix verify-previous-version Makefile target
Bumps google.golang.org/protobuf from 1.32.0 to 1.33.0.
…-pick-132-to-release-0.3

[release-0.3] Bump google.golang.org/protobuf from 1.32.0 to 1.33.0
Currently, installing the latest z version of golang from the go
toolchain available in the repository (via go get) is failing with the
following error:

go: updating go.mod requires go >= 1.21.8 (running go 1.21.7; GOTOOLCHAIN=local)

To fix it, this change installs directly the wanted version from
https://golang.org/dl without using the distribution repository.

Signed-off-by: Carlo Lobrano <c.lobrano@gmail.com>
…-pick-133-to-release-0.3

[release-0.3] Fix Go install in Dockerfile
Signed-off-by: Carlo Lobrano <c.lobrano@gmail.com>
…-pick-136-to-release-0.3

[release-0.3] Reduce logging level
OKD community pipeline is verifying the presence of OCP annotation.

Signed-off-by: Carlo Lobrano <c.lobrano@gmail.com>
Copy link
Contributor

openshift-ci bot commented Aug 8, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Aug 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@clobrano
Copy link
Contributor Author

clobrano commented Aug 8, 2024

uhm, no

@clobrano clobrano closed this Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants