Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twisted 24.7.0 fixes #400

Merged
merged 5 commits into from
Aug 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/python3.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,12 @@ jobs:
strategy:
matrix:
python-version: ["3.8", "3.9", "3.10"]
twisted-version: [tx18, tx19, tx20, tx21]
twisted-version: [tx18, tx19, tx20, tx21, tx22, tx23, tx24]
include:
- python-version: "3.11"
twisted-version: "tx22"
twisted-version: "tx24"
- python-version: "3.12"
twisted-version: "tx24"

steps:
- uses: actions/checkout@v2
Expand Down
1 change: 1 addition & 0 deletions docs/releases.rst
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ See also :ref:`api_stability`.

`git main <https://github.com/meejah/txtorcon>`_ *will likely become v24.1.0*

* Fix (test) issues with Twisted 24.7.0 (`#400 <https://github.com/meejah/txtorcon/pull/400>`_)
* Remove usage of "six" (`#395 <https://github.com/meejah/txtorcon/issues/395>`_,
from `a-dieste <https://github.com/a-detiste>`_

Expand Down
7 changes: 5 additions & 2 deletions test/test_torconfig.py
Original file line number Diff line number Diff line change
Expand Up @@ -1457,8 +1457,11 @@ def __call__(self, proto, trans):
)
self.assertIs(tpp, fake_tor.process)
calls = warn.mock_calls
self.assertEqual(1, len(calls))
self.assertEqual(calls[0][1][1], DeprecationWarning)
# on Twisted 24.7.0 and higher, there's an extra deprecation
# warning due to returnValue being deprecated
self.assertTrue(len(calls) >= 1)
for call in calls:
self.assertEqual(call[1][1], DeprecationWarning)


class ErrorTests(unittest.TestCase):
Expand Down
4 changes: 3 additions & 1 deletion tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
# stretch: 16.3.0-1

[tox]
envlist = clean,flake8,stats,readme_render,{py36,py37,py38,py39,pypy}-{tx18,tx19,tx20},{py36,py37,py38,py39}-tx21,{py310,py311}-tx22
envlist = clean,flake8,stats,readme_render,{py36,py37,py38,py39,pypy}-{tx18,tx19,tx20,tx21,tx22,tx23,tx24},{py36,py37,py38,py39}-tx21,{py310,py311}-tx22
# if you're not using detox, you can use this list to get
# "all environments" coverage stats:
# tox -e 'clean,flake8,py39-tx20,pypy-tx20,py35-tx20,stats'
Expand Down Expand Up @@ -44,6 +44,8 @@ deps=
tx20: twisted>=20.0.0,<21.0.0
tx21: twisted>=21.0.0,<22.0.0
tx22: twisted>=22.0.0,<23.0.0
tx23: twisted>=23.0.0,<24.0.0
tx24: twisted>=24.0.0,<25.0.0

# [gh-actions]
# python =
Expand Down
Loading