Version for windows python module is very hard

meelgroup · Oct 14, 2023 · d673b03 · d673b03
1 parent 61b534d
commit d673b03
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/python/src/pyapproxmc.cpp b/python/src/pyapproxmc.cpp
@@ -450,6 +450,8 @@ PyMODINIT_FUNC PyInit_pyapproxmc(void)
 
     // Add the version string
     // they're using.
+#if defined(_MSC_VER)
+#else
     if (PyModule_AddStringConstant(m, "__version__", APPMC_FULL_VERSION) == -1) {
         Py_DECREF(m);
         return NULL;
@@ -458,6 +460,7 @@ PyMODINIT_FUNC PyInit_pyapproxmc(void)
         Py_DECREF(m);
         return NULL;
     }
+#endif
 
     // Add the Counter type
     Py_INCREF(&pyapproxmc_CounterType);

diff --git a/setup.py b/setup.py
@@ -48,7 +48,7 @@ def _parse_toml(pyproject_path):
 
 def gen_modules(version):
     if platform == "win32" or platform == "cygwin":
-        extra_compile_args_val = ['/std:c++17', "/DCMS_LOCAL_BUILD=1", "/DAPPMC_FULL_VERSION=\"\\\""+version+"\"\\\""]
+        extra_compile_args_val = ['/std:c++17', "/DCMS_LOCAL_BUILD=1", "/DAPPMC_FULL_VERSION=\""+version+"\""]
         define_macros_val = [("TRACE", "")]
 
     else: