Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed test to match python API and update README to match output #36

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

alvarna
Copy link
Contributor

@alvarna alvarna commented Aug 11, 2023

Hi,

Thanks for the tool ! Looks like the python test was using an older API. I updated it to pass the projection set to the count function and updated the README to match the output, which is represented differently (but numerically the same).

Copy link
Collaborator

@msoos msoos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nice! Thank you! I have actually pushed a change to the README... however, I would very much appreciate the fix to the test_pyapproxmc.py. Can you please change this PR to only contain the diff to the test and then I will approve & merge?

Thanks so much again,

Mate

@alvarna
Copy link
Contributor Author

alvarna commented Aug 14, 2023

The update in this PR was different from #37 - This updates the example in the README in the root of the repo from
Approximate count is: 88*2**13
to:
Approximate count is: 11*2**16
which matches the output I get currently. These are numerically the same values, but it looks like the no. of hashes has increased, and the no. of cells has correspondingly reduced. Similarly, for the second example, the output from the current version is Approximate count is: 7*2**6 (instead of 56*2**3).

I can update the example in the python README to match this as well, if you wish. Or if you prefer to leave it with the old output, that is fine with me as well. Let me know how you would like to proceed.

@msoos msoos merged commit d8889e0 into meelgroup:master Aug 14, 2023
3 checks passed
@msoos
Copy link
Collaborator

msoos commented Aug 14, 2023

Thanks this is perfect! Thanks for updating it to the currently displayed one :) Really nice! Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants