improve error reporting for Python bindings #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msoos
approved these changes
Dec 21, 2023
|
OK, I'm releasing a new version, so new pip module will be released :) |
|
Release will appear on PIP as module version ApproxMC 4.1.22. Thanks again!! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves the exceptions thrown by the Python bindings. (I'm creating a separate PR, because this changes the API in a minor way).
According to the Python Documentation the
SystemErrorexception should only be thrown if the interpreter encounters an internal error. I thinkValueErrorworks better here. Also, I changed a message that was probably copy-pasted wrong.