Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure clamav on MacOS #133

Closed
wants to merge 2 commits into from
Closed

Configure clamav on MacOS #133

wants to merge 2 commits into from

Conversation

enggnr
Copy link
Contributor

@enggnr enggnr commented Dec 21, 2023

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Creates services to run ClamAV scan and update periodically

  • What is the current behavior? (You can also link to an open issue here)
    There are no services that provide this feature at this time.

  • Other information:
    Fixes ClamAV on macOS #125.

Copy link

github-actions bot commented Dec 21, 2023

Image description CodeRabbit


Uplevel your code reviews with CodeRabbit Pro

CodeRabbit Pro

If you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Commits Files that changed from the base of the PR and between 8ed3ec6 and b641796 commits.
Files selected (3)
  • home/dot_local/etc/clamav/freshclam.conf (2)
  • home/dot_local/etc/clamav/installdoctor.clamdscan.plist.tmpl (1)
  • home/dot_local/etc/clamav/installdoctor.freshclam.plist.tmpl (1)
Files ignored due to filter (1)
  • software.yml
Files not summarized due to errors (3)
  • home/dot_local/etc/clamav/installdoctor.clamdscan.plist.tmpl (nothing obtained from openai)
  • home/dot_local/etc/clamav/freshclam.conf (nothing obtained from openai)
  • home/dot_local/etc/clamav/installdoctor.freshclam.plist.tmpl (nothing obtained from openai)
Files not reviewed due to errors (3)
  • home/dot_local/etc/clamav/installdoctor.clamdscan.plist.tmpl (no response)
  • home/dot_local/etc/clamav/freshclam.conf (no response)
  • home/dot_local/etc/clamav/installdoctor.freshclam.plist.tmpl (no response)
Review comments generated (0)
  • Review: 0
  • LGTM: 0

Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

@ProfessorManhattan
Copy link
Contributor

Hey @enggnr -- can you please resolve the merge conflicts on this and nix the installdoctor branding on the file names? The files should be short and concise.

For example, we should not use /var/log/installdoctor and instead use /var/log/clamav instead:

sudo mkdir -p /var/log/installdoctor
        sudo chown $USER /var/log/installdoctor
        sudo cp -f "$HOME/.local/etc/clamav/installdoctor.clamdscan.plist.tmpl" /Library/LaunchDaemons/installdoctor.clamdscan.plist
        sudo cp -f "$HOME/.local/etc/clamav/installdoctor.freshclam.plist.tmpl" /Library/LaunchDaemons/installdoctor.freshclam.plist
        sudo launchctl load -w /Library/LaunchDaemons/installdoctor.clamdscan.plist
        sudo launchctl load -w /Library/LaunchDaemons/installdoctor.freshclam.plist

@enggnr
Copy link
Contributor Author

enggnr commented Dec 28, 2023

@ProfessorManhattan, comments address. Please review.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Commits Files that changed from the base of the PR and between 15d4922 and be6858a commits.
Files selected (3)
  • home/dot_local/etc/clamav/clamdscan.plist.tmpl (1)
  • home/dot_local/etc/clamav/freshclam.conf (2)
  • home/dot_local/etc/clamav/freshclam.plist.tmpl (1)
Files ignored due to filter (1)
  • software.yml
Files not summarized due to errors (3)
  • home/dot_local/etc/clamav/freshclam.conf (nothing obtained from openai)
  • home/dot_local/etc/clamav/clamdscan.plist.tmpl (nothing obtained from openai)
  • home/dot_local/etc/clamav/freshclam.plist.tmpl (nothing obtained from openai)
Files not reviewed due to errors (3)
  • home/dot_local/etc/clamav/freshclam.conf (no response)
  • home/dot_local/etc/clamav/freshclam.plist.tmpl (no response)
  • home/dot_local/etc/clamav/clamdscan.plist.tmpl (no response)
Review comments generated (0)
  • Review: 0
  • LGTM: 0

Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

@enggnr enggnr assigned ProfessorManhattan and unassigned enggnr Dec 28, 2023
@ProfessorManhattan
Copy link
Contributor

Added this one manually... thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ClamAV on macOS
2 participants