Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update application backup settings #131

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update application backup settings #131

wants to merge 1 commit into from

Conversation

enggnr
Copy link
Contributor

@enggnr enggnr commented Dec 15, 2023

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Adds folder locations to back up apps using Mackup for the different plaforms

  • What is the current behavior? (You can also link to an open issue here)
    This is done differently but it is not sufficient to address the various locations that can be used to store app settings (which depends on the installation method)

  • Other information:
    Fixes Application Settings Backup #129

NOTE

  • Logitech Options+ does not install when using Chocolatey. This needs to be revisited once that is working to add the correct path
  • Tor-browser does not install when using Chocolatey. Tested this by creating a local package, may need to revisit once it is working without having to do the manual fix

ProfessorManhattan
ProfessorManhattan requested changes Dec 23, 2023
View reviewed changes
Copy link
Contributor

@ProfessorManhattan ProfessorManhattan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @enggnr - can you please resolve merge conflicts on this one

@enggnr
Copy link
Contributor Author

enggnr commented Dec 28, 2023

@ProfessorManhattan, this is complete.

@enggnr enggnr assigned ProfessorManhattan and unassigned enggnr Dec 28, 2023
@ProfessorManhattan
Copy link
Contributor

Hey @enggnr -- sorry about this but can you reformat the commit to use the new _env: parameter that you can search for on other entries? Please commit the updates right to master because merging software.yml is tricky since I keep updating it. Also, please add the variables into home/dot_config/shell/apps.sh.tmpl as well as home/dot_config/autorestic. You can open a seperate PR or just merge it all to master directly since it is all pretty straight forward.

@enggnr
Copy link
Contributor Author

enggnr commented Apr 27, 2024

@ProfessorManhattan, added missing values in home/dot_config/shell/apps.sh.tmpl in the commit 1bb6448.

Do we want the _link fields that were added as part of this PR in the master branch? These were created following this README. If they are needed, I'll add them and the values of _env fields where missing.

@enggnr enggnr assigned ProfessorManhattan and unassigned enggnr Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ProfessorManhattan ProfessorManhattan ProfessorManhattan requested changes

Assignees

@ProfessorManhattan ProfessorManhattan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Application Settings Backup
2 participants
@enggnr @ProfessorManhattan