-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SLD styles to image mosaics #160
Conversation
a4cc649
to
26ba161
Compare
@jdk24 I tested the PR in my mocked environment. However it would be useful to test it in a more real environment before merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Works as expected when tested on incoming raster with existing style until #145.
For our setup this is great. Can there be cases where searching for "_no_" in the layer name is too generic? Otherwise it's a yes from me.
@jdk24 Thanks for testing!! the filtering for pollutants happens here: https://github.com/meggsimum/sauber-sdi-docker/pull/160/files#diff-ca92621faca806ac3b80fe78d54e869f91ea735480602d00a3e730e33cddc7ebR250-R256 it always searches for Therefore it should not confuse |
It would've helped if I had escaped the underscores :) Then again, this would make it just as project-specific, so I'm going to leave it with the approval. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me.
As discussed: Once the final SLDs are put into this, it can be merged.
@jdk24 I updated the SLD and added the ones for SIM. If this is fine for you we can merge. |
references #145
geoserver_init
no
,no2
,pm10
) is chosen depending on the layer name