Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support v1.3.5 #50

Merged
merged 2 commits into from
Aug 14, 2020
Merged

feat: add support v1.3.5 #50

merged 2 commits into from
Aug 14, 2020

Conversation

clwluvw
Copy link
Collaborator

@clwluvw clwluvw commented Aug 7, 2020

Closes: #44

@clwluvw clwluvw added the enhancement New feature or request label Aug 7, 2020
@clwluvw clwluvw requested a review from mehdy August 7, 2020 14:41
@clwluvw
Copy link
Collaborator Author

clwluvw commented Aug 7, 2020

@mehdy Should I add test for this v1.3.5 or we can wait for #47?

@mehdy
Copy link
Owner

mehdy commented Aug 8, 2020

@clwluvw I think adding tests and fixing this issue faster is a better option.

@clwluvw clwluvw force-pushed the v1.3.5-support branch 2 times, most recently from 1a1002f to dc95ed6 Compare August 8, 2020 13:41
@clwluvw
Copy link
Collaborator Author

clwluvw commented Aug 8, 2020

@mehdy Tests has been added. Ready for review.

Makefile Outdated Show resolved Hide resolved
internal/collector/signal.go Outdated Show resolved Hide resolved
internal/collector/signal.go Show resolved Hide resolved
internal/collector/signal.go Show resolved Hide resolved
internal/collector/utils.go Outdated Show resolved Hide resolved
@clwluvw clwluvw requested a review from mehdy August 13, 2020 13:16
Copy link
Owner

@mehdy mehdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mehdy mehdy merged commit 5a2e9f2 into master Aug 14, 2020
@clwluvw clwluvw deleted the v1.3.5-support branch August 14, 2020 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot start exporter: unexpected end of JSON input
2 participants