Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer function visuals #178

Open
wants to merge 5 commits into
base: vector-prototype
Choose a base branch
from
Open

Conversation

talonchandler
Copy link
Collaborator

@talonchandler talonchandler commented Nov 8, 2024

This PR adds visualization scripts for the Green's tensor spectrum and transfer functions.

Tagging @mattersoflight, @edyoshikun, @ieivanov who have requested these.

Running these scripts results in:

Screen.Recording.2024-11-08.at.1.33.04.PM.mov
Screen.Recording.2024-11-08.at.2.01.11.PM.mov

@talonchandler talonchandler marked this pull request as ready for review November 8, 2024 22:06
Copy link
Member

@mattersoflight mattersoflight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @talonchandler, these scripts work well! I tested on Mac.

Surface rendering of the support of the Green's tensor spectrum just like you surface render support of OTFs will lead to a more intuitive and compelling visualization.

Minor point: For visualization and slides, the dark theme looks better to me.

image

@talonchandler
Copy link
Collaborator Author

talonchandler commented Nov 12, 2024

Surface rendering of the support of the Green's tensor spectrum just like you surface render support of OTFs will lead to a more intuitive and compelling visualization.

I agree, I will iterate here. The aliasing and colormapping are making the volume renders suboptimal. I'll need to get a "marching cubes" or similar algorithm connected to napari's surface layer, but I don't expect an enormous lift.

Minor point: For visualization and slides, the dark theme looks better to me.

Sounds good, I can return to that default after changing to a surface rendered Green's.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants