chore: 🤦 I should implement tests as soon as possible

meili-NG · Feb 12, 2022 · 8977d25 · 8977d25
1 parent 121dd99
commit 8977d25
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/common/utils.ts b/src/common/utils.ts
@@ -38,6 +38,8 @@ export function isValidUri(...values: (string | undefined)[]): boolean {
 export function isNotBlank(...values: (string | undefined | null)[]): boolean {
   let isValid = true;
   for (const value of values) {
+    if (!value) return false;
+
     isValid = isValid && !(value === undefined || value === null || value === '' || value.trim().length === 0);
     if (!isValid) return false;
   }

diff --git a/src/routes/v1/admin/users/index.ts b/src/routes/v1/admin/users/index.ts
@@ -109,7 +109,7 @@ const usersAdminHandler = (app: FastifyInstance, opts: FastifyPluginOptions, don
 
     if (!hasRequirementsMet)
       return Meiling.V1.Error.sendMeilingError(rep, Meiling.V1.Error.ErrorType.INVALID_REQUEST, 'Invalid Username');
-    if (Utils.isValidName(data.name))
+    if (!Utils.isValidName(data.name))
       return Meiling.V1.Error.sendMeilingError(rep, Meiling.V1.Error.ErrorType.INVALID_REQUEST, 'Invalid Name');
 
     const name = data.name;