From 8977d25b8f5dfdf3591e7527ed0f0d86b32969a0 Mon Sep 17 00:00:00 2001 From: Alex4386 Date: Sat, 12 Feb 2022 17:25:02 +0900 Subject: [PATCH] chore: :facepalm: I should implement tests as soon as possible --- src/common/utils.ts | 2 ++ src/routes/v1/admin/users/index.ts | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/common/utils.ts b/src/common/utils.ts index 8a0a0a6a..e6511bcc 100644 --- a/src/common/utils.ts +++ b/src/common/utils.ts @@ -38,6 +38,8 @@ export function isValidUri(...values: (string | undefined)[]): boolean { export function isNotBlank(...values: (string | undefined | null)[]): boolean { let isValid = true; for (const value of values) { + if (!value) return false; + isValid = isValid && !(value === undefined || value === null || value === '' || value.trim().length === 0); if (!isValid) return false; } diff --git a/src/routes/v1/admin/users/index.ts b/src/routes/v1/admin/users/index.ts index 1bf63560..2899f509 100644 --- a/src/routes/v1/admin/users/index.ts +++ b/src/routes/v1/admin/users/index.ts @@ -109,7 +109,7 @@ const usersAdminHandler = (app: FastifyInstance, opts: FastifyPluginOptions, don if (!hasRequirementsMet) return Meiling.V1.Error.sendMeilingError(rep, Meiling.V1.Error.ErrorType.INVALID_REQUEST, 'Invalid Username'); - if (Utils.isValidName(data.name)) + if (!Utils.isValidName(data.name)) return Meiling.V1.Error.sendMeilingError(rep, Meiling.V1.Error.ErrorType.INVALID_REQUEST, 'Invalid Name'); const name = data.name;