Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#256 ndjson/csv methods to add #309

Closed
wants to merge 6 commits into from
Closed

#256 ndjson/csv methods to add #309

wants to merge 6 commits into from

Conversation

diegonavarroq
Copy link
Contributor

@diegonavarroq diegonavarroq commented Jan 7, 2022 •
edited by alallema
Loading

Pull Request

What does this PR do?

Added addDocumentsCSV and addDocumentsNDJSON methods with respective tests.
Added addDocumentsCSVinBatches and addDocumentsNDJSONinBatches methods with respective tests.
Fixes #256

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to MeiliSearch!

@curquiza curquiza requested a review from alallema January 10, 2022 09:25
@curquiza curquiza added the enhancement New feature or request label Jan 10, 2022
@curquiza
Copy link
Member

Thanks @diegonavarroq for the PR, @alallema will review it when she will have the time

@alallema, #256 should NOT be closed when this PR si merged since all the methods will not be implemented yet

@diegonavarroq diegonavarroq marked this pull request as draft January 13, 2022 20:08
@diegonavarroq
Copy link
Contributor Author

I have a problem with integration tests because when I do those tests locally it passes them but when I commit and push it fails and I have no way of seeing what causes them to fail, I would appreciate a little help with that. This is happening in PR #309 and #312. @curquiza @alallema

@diegonavarroq diegonavarroq marked this pull request as ready for review January 14, 2022 17:28
@alallema
Copy link
Contributor

Hi @diegonavarroq,
Indeed, the last release of Meilisearch took place last week. So tests are now running with Mielisearch v0.25.0. So sorry for the inconvenience.
I currently updating this SDK I think the best to merge your PR is to wait until I finish this update and I will take care of integrating your code afterward if it's ok for you.

@alallema
Copy link
Contributor

alallema commented Feb 9, 2022

Hi @diegonavarroq,
Sorry for the delay. SDK update is done, is it ok for you if I handle all conflicts in GitHub, or would you rather do it? Thank again for the PR ❤️

@diegonavarroq
Copy link
Contributor Author

Hi @diegonavarroq, Sorry for the delay. SDK update is done, is it ok for you if I handle all conflicts in GitHub, or would you rather do it? Thank again for the PR ❤️

@diegonavarroq
Copy link
Contributor Author

I can handle with the GitHub conflicts

@diegonavarroq diegonavarroq reopened this Feb 17, 2022
@alallema alallema added the stale Pull request or issue that has recieve no activity for a long time. label Jun 2, 2022
@diegonavarroq diegonavarroq closed this by deleting the head repository Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alallema alallema Awaiting requested review from alallema

Assignees
No one assigned
Labels
enhancement New feature or request stale Pull request or issue that has recieve no activity for a long time.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NDJSON/CSV methods to add and update documents
3 participants
@diegonavarroq @curquiza @alallema