Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error message when adding a wrong localhost URL #4811 #4981

Closed
wants to merge 1 commit into from
Closed

Improve error message when adding a wrong localhost URL #4811 #4981

wants to merge 1 commit into from

Conversation

waks11
Copy link

@waks11 waks11 commented Oct 3, 2024

Pull Request

Related issue

Fixes meilisearch/meilisearch-python#1028

What does this PR do?

  • Improves the error message returned when a URL lacks the required scheme (protocol). Ensures that users receive a clearer message explaining that the URL is missing a protocol and makes suggestions

PR checklist

Please check if your PR fulfills the following requirements:

  • [ /] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • [/ ] Have you read the contributing guidelines?
  • [/ ] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@curquiza curquiza requested a review from irevoire October 7, 2024 12:59
@irevoire
Copy link
Member

irevoire commented Oct 8, 2024

Hey @waks11,

Sorry, this issue is a bit misleading.
The error message you’re trying to improve cannot be returned by Meilisearch because it only happens when we can’t reach Meilisearch.
So, the if you added here cannot ever be triggered. We should move the issue to the Python SDK instead of Meilisearch.
Thanks for your time 🙏

@irevoire irevoire closed this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irevoire irevoire Awaiting requested review from irevoire

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve error message when adding a wrong localhost URL
2 participants
@waks11 @irevoire