Skip to content

Commit

Permalink
fix: Append batch config if target supports the batch capability
Browse files Browse the repository at this point in the history
  • Loading branch information
edgarrmondragon committed Jul 27, 2023
1 parent b0a8621 commit 11c22ee
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions singer_sdk/target_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
from singer_sdk.helpers._classproperty import classproperty
from singer_sdk.helpers._compat import final
from singer_sdk.helpers.capabilities import (
BATCH_CONFIG,
TARGET_SCHEMA_CONFIG,
CapabilitiesEnum,
PluginCapabilities,
Expand Down Expand Up @@ -614,6 +615,9 @@ def _merge_missing(source_jsonschema: dict, target_jsonschema: dict) -> None:
if TargetCapabilities.TARGET_SCHEMA in capabilities:
_merge_missing(TARGET_SCHEMA_CONFIG, config_jsonschema)

if PluginCapabilities.BATCH in capabilities:
_merge_missing(BATCH_CONFIG, config_jsonschema)

Check warning on line 619 in singer_sdk/target_base.py

View check run for this annotation

Codecov / codecov/patch

singer_sdk/target_base.py#L619

Added line #L619 was not covered by tests

super().append_builtin_config(config_jsonschema)

pass

0 comments on commit 11c22ee

Please sign in to comment.