Address dynamic class attributes and TODO comments

meltano · Aug 1, 2023 · be80c3b · be80c3b
1 parent e0b4e0d
commit be80c3b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/...{cookiecutter.library_name}}/{%if 'SQL' != cookiecutter.stream_type %}streams.py{%endif%} b/...{cookiecutter.library_name}}/{%if 'SQL' != cookiecutter.stream_type %}streams.py{%endif%}
@@ -2,6 +2,7 @@
 
 from __future__ import annotations
 
+import typing as t
 from pathlib import Path
 
 from singer_sdk import typing as th  # JSON Schema typing helpers
@@ -54,7 +55,7 @@ class UsersStream({{ cookiecutter.source_name }}Stream):
             ),
         ),
     ).to_dict()
-    primary_keys = ["id"]
+    primary_keys: t.ClassVar[list[str]] = ["id"]
     replication_key = None
     graphql_query = """
         users {
@@ -81,7 +82,7 @@ class GroupsStream({{ cookiecutter.source_name }}Stream):
         th.Property("id", th.StringType),
         th.Property("modified", th.DateTimeType),
     ).to_dict()
-    primary_keys = ["id"]
+    primary_keys: t.ClassVar[list[str]] = ["id"]
     replication_key = "modified"
     graphql_query = """
         groups {
@@ -104,7 +105,7 @@ class UsersStream({{ cookiecutter.source_name }}Stream):
 {%- if cookiecutter.stream_type == "REST" %}
     path = "/users"
 {%- endif %}
-    primary_keys = ["id"]
+    primary_keys: t.ClassVar[list[str]] = ["id"]
     replication_key = None
     # Optionally, you may also use `schema_filepath` in place of `schema`:
     # schema_filepath = SCHEMAS_DIR / "users.json"  # noqa: ERA001
@@ -143,7 +144,7 @@ class GroupsStream({{ cookiecutter.source_name }}Stream):
 {%- if cookiecutter.stream_type == "REST" %}
     path = "/groups"
 {%- endif %}
-    primary_keys = ["id"]
+    primary_keys: t.ClassVar[list[str]] = ["id"]
     replication_key = "modified"
     schema = th.PropertiesList(
         th.Property("name", th.StringType),

diff --git a/noxfile.py b/noxfile.py
@@ -22,7 +22,7 @@
 
 RUFF_OVERRIDES = """\
 extend = "./pyproject.toml"
-extend-ignore = ["TD002", "TD003"]
+extend-ignore = ["TD002", "TD003", "FIX002"]
 """
 
 COOKIECUTTER_REPLAY_FILES = list(Path("./e2e-tests/cookiecutters").glob("*.json"))