Skip to content

Commit

Permalink
Merge branch 'main' into cache_sql_columns_and_schemas
Browse files Browse the repository at this point in the history
  • Loading branch information
edgarrmondragon authored Oct 3, 2023
2 parents fc7d434 + 7adc1a8 commit d68e68f
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 8 deletions.
1 change: 1 addition & 0 deletions .flake8
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
[flake8]
max-line-length = 88
exclude = cookiecutter
ignore = E, W
per-file-ignores =
# Don't require docstrings conventions in private modules
singer_sdk/helpers/_*.py:DAR
Expand Down
4 changes: 2 additions & 2 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -36,14 +36,14 @@ repos:
)$
- repo: https://github.com/python-jsonschema/check-jsonschema
rev: 0.26.3
rev: 0.27.0
hooks:
- id: check-dependabot
- id: check-github-workflows
- id: check-readthedocs

- repo: https://github.com/astral-sh/ruff-pre-commit
rev: v0.0.291
rev: v0.0.292
hooks:
- id: ruff
args: [--fix, --exit-non-zero-on-fix, --show-fixes]
Expand Down
4 changes: 0 additions & 4 deletions singer_sdk/target_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -607,8 +607,6 @@ def _merge_missing(source_jsonschema: dict, target_jsonschema: dict) -> None:

super().append_builtin_config(config_jsonschema)

pass


class SQLTarget(Target):
"""Target implementation for SQL destinations."""
Expand Down Expand Up @@ -672,8 +670,6 @@ def _merge_missing(source_jsonschema: dict, target_jsonschema: dict) -> None:

super().append_builtin_config(config_jsonschema)

pass

@final
def add_sqlsink(
self,
Expand Down
2 changes: 1 addition & 1 deletion singer_sdk/testing/templates.py
Original file line number Diff line number Diff line change
Expand Up @@ -337,4 +337,4 @@ def singer_filepath(self) -> Path:
Returns:
The expected Path to this tests singer file.
"""
return resources.files(target_test_streams).joinpath(f"{self.name}.singer") # type: ignore[no-any-return] # noqa: E501
return resources.files(target_test_streams).joinpath(f"{self.name}.singer") # type: ignore[no-any-return]
2 changes: 1 addition & 1 deletion tests/core/test_io.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def _process_state_message(self, message_dict: dict) -> None:
id="unparsable",
),
pytest.param(
'{"type": "RECORD", "stream": "users", "record": {"id": 1, "value": 1.23}}', # noqa: E501
'{"type": "RECORD", "stream": "users", "record": {"id": 1, "value": 1.23}}',
{
"type": "RECORD",
"stream": "users",
Expand Down

0 comments on commit d68e68f

Please sign in to comment.