From fa25c464aef78f6d8596f66c32bf873695767a1c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edgar=20Ram=C3=ADrez=20Mondrag=C3=B3n?= Date: Fri, 22 Sep 2023 09:29:01 -0600 Subject: [PATCH] fix: Fix hanging downstream tests in tap-postgres (#1977) Investigate use of future=True --- pyproject.toml | 3 +++ singer_sdk/connectors/sql.py | 2 -- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/pyproject.toml b/pyproject.toml index 3c81cfeb9..06d77f35a 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -267,6 +267,9 @@ select = [ ] src = ["samples", "singer_sdk", "tests"] target-version = "py37" +unfixable = [ + "ERA", # Don't remove commented out code +] [tool.ruff.per-file-ignores] "docs/conf.py" = [ diff --git a/singer_sdk/connectors/sql.py b/singer_sdk/connectors/sql.py index 87dd9f6b6..c74726057 100644 --- a/singer_sdk/connectors/sql.py +++ b/singer_sdk/connectors/sql.py @@ -325,7 +325,6 @@ def create_engine(self) -> Engine: return sqlalchemy.create_engine( self.sqlalchemy_url, echo=False, - future=True, json_serializer=self.serialize_json, json_deserializer=self.deserialize_json, ) @@ -336,7 +335,6 @@ def create_engine(self) -> Engine: return sqlalchemy.create_engine( self.sqlalchemy_url, echo=False, - future=True, ) def quote(self, name: str) -> str: