Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Tap crashes when start_date and replication value are not both tz-aware or viceversa #2612

Closed
1 task
edgarrmondragon opened this issue Aug 20, 2024 · 0 comments · Fixed by #2613
Closed
1 task
Assignees
Labels
kind/Bug Something isn't working valuestream/SDK

Comments

@edgarrmondragon
Copy link
Collaborator

Singer SDK Version

0.39.1

Is this a regression?

  • Yes

Python Version

NA

Bug scope

Taps (catalog, state, etc.)

Operating System

NA

Description

I think the issue is caused by the SDK parsing these two values into a naive and an aware datetime objects respectively:

  • 2024-01-01T00:00:00Z
  • 2024-01-01T00:00:00

@fekle as a workaround, could you try changing the value of the start_date setting to have an offset? i.e. either Z, +00:00 or the more appropriate one. I'll also raise an issue in meltano/sdk for better handling of this type of edge cases.

Originally posted by @edgarrmondragon in MeltanoLabs/tap-klaviyo#19 (comment)

Code

>>> datetime.datetime.fromisoformat('2024-01-01T00:00:00Z')
datetime.datetime(2024, 1, 1, 0, 0, tzinfo=datetime.timezone.utc)
>>> datetime.datetime.fromisoformat('2024-01-01T00:00:00')
datetime.datetime(2024, 1, 1, 0, 0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/Bug Something isn't working valuestream/SDK
Projects
None yet
1 participant