Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Test with Python 3.12 🐍 #1733

Merged
merged 4 commits into from
Dec 11, 2023
Merged

feat: Test with Python 3.12 🐍 #1733

merged 4 commits into from
Dec 11, 2023

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented May 24, 2023

@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8e95043) 87.72% compared to head (2a3457d) 87.72%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1733   +/-   ##
=======================================
  Coverage   87.72%   87.72%           
=======================================
  Files          60       60           
  Lines        4946     4946           
  Branches     1007     1007           
=======================================
  Hits         4339     4339           
  Misses        425      425           
  Partials      182      182           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 30, 2023

CodSpeed Performance Report

Merging #1733 will not alter performance

Comparing chore/python-3.12 (2a3457d) with main (8e95043)

Summary

✅ 6 untouched benchmarks

@edgarrmondragon edgarrmondragon force-pushed the chore/python-3.12 branch 2 times, most recently from 64b1c77 to 6d8c336 Compare November 21, 2023 19:42
@edgarrmondragon edgarrmondragon force-pushed the chore/python-3.12 branch 5 times, most recently from 77aeb0d to f80fb86 Compare December 5, 2023 23:28
@edgarrmondragon edgarrmondragon force-pushed the chore/python-3.12 branch 2 times, most recently from b414074 to ac79c56 Compare December 8, 2023 20:06
@edgarrmondragon edgarrmondragon changed the title feat: Support Python 3.12 🐍 feat: Test with Python 3.12 🐍 Dec 11, 2023
@edgarrmondragon edgarrmondragon marked this pull request as ready for review December 11, 2023 16:52
@edgarrmondragon edgarrmondragon requested review from a team and kgpayne as code owners December 11, 2023 16:52
@edgarrmondragon
Copy link
Collaborator Author

Merging this with message Test with Python 3.12 as:

  • DuckDB (only used for testing) does not support Python 3.12 yet
  • Pendulum can only be built on Python 3.12 (and has wheels) starting with prerelease 3.0.0b1

@edgarrmondragon edgarrmondragon merged commit 299acc0 into main Dec 11, 2023
33 checks passed
@edgarrmondragon edgarrmondragon deleted the chore/python-3.12 branch December 11, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant