Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(targets): Safely skip parsing record field as date-time if it is missing in schema #1844

Merge branch 'main' into 1836-bug-_parse_timestamps_in_record-throws-…

20ca4b1
Select commit
Loading
Failed to load commit list.
Merged

fix(targets): Safely skip parsing record field as date-time if it is missing in schema #1844

Merge branch 'main' into 1836-bug-_parse_timestamps_in_record-throws-…
20ca4b1
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 28, 2023 in 0s

87.39% (+0.22%) compared to fe7d7d6

View this Pull Request on Codecov

87.39% (+0.22%) compared to fe7d7d6

Details

Codecov Report

Merging #1844 (20ca4b1) into main (fe7d7d6) will increase coverage by 0.22%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main    #1844      +/-   ##
==========================================
+ Coverage   87.16%   87.39%   +0.22%     
==========================================
  Files          59       59              
  Lines        5120     5123       +3     
  Branches      827      828       +1     
==========================================
+ Hits         4463     4477      +14     
+ Misses        463      451      -12     
- Partials      194      195       +1     
Files Coverage Δ
singer_sdk/sinks/core.py 93.33% <83.33%> (+4.44%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more