Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: SQLTarget connector instance shared with sinks #1864

Merged
merged 23 commits into from
Jul 28, 2023
Merged

feat: SQLTarget connector instance shared with sinks #1864

merged 23 commits into from
Jul 28, 2023

Commits on Jul 20, 2023

  1. added _target_conector and property

    @BuzzCutNorman
    BuzzCutNorman committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    4a84b47 View commit details
    Browse the repository at this point in the history

  2. added add_sqlsink and update get_sink to call it

    @BuzzCutNorman
    BuzzCutNorman committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    e3d31e9 View commit details
    Browse the repository at this point in the history

  3. add default_sink_class type hint SQLSink

    @BuzzCutNorman
    BuzzCutNorman committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    c50a933 View commit details
    Browse the repository at this point in the history

  4. remove default_sink_class type hint, get_sink and add_sqlsink return … 

    …type Sink.
    @BuzzCutNorman
    BuzzCutNorman committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    6f7dd00 View commit details
    Browse the repository at this point in the history

  5. added final decorator to add_sqlsink

    @BuzzCutNorman
    BuzzCutNorman committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    cc74008 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2023

  1. Merge branch 'main' into 1772-sqltarget-level-connector-instance-shar… 

    …ed-with-sinks
    @BuzzCutNorman
    BuzzCutNorman authored Jul 21, 2023
    Configuration menu
    Copy the full SHA
    7aa87f9 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2023

  1. Merge branch 'main' into 1772-sqltarget-level-connector-instance-shar… 

    …ed-with-sinks
    @BuzzCutNorman
    BuzzCutNorman authored Jul 25, 2023
    Configuration menu
    Copy the full SHA
    e571343 View commit details
    Browse the repository at this point in the history

  2. mypy fixes round 2, added get_sink_class

    @BuzzCutNorman
    BuzzCutNorman committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    d6f95ed View commit details
    Browse the repository at this point in the history

  3. Merge branch '1772-sqltarget-level-connector-instance-shared-with-sin… 

    …ks' of https://github.com/BuzzCutNorman/sdk into 1772-sqltarget-level-connector-instance-shared-with-sinks
    @BuzzCutNorman
    BuzzCutNorman committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    e223612 View commit details
    Browse the repository at this point in the history

  4. mypy round 3: removed get_sink_class

    @BuzzCutNorman
    BuzzCutNorman committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    0413e0b View commit details
    Browse the repository at this point in the history

  5. mypy attempt 4: add Sink type hints

    @BuzzCutNorman
    BuzzCutNorman committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    c9fce83 View commit details
    Browse the repository at this point in the history

  6. mypy attempt 5: default_sink_class as Any

    @BuzzCutNorman
    BuzzCutNorman committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    b70b965 View commit details
    Browse the repository at this point in the history

  7. mypy attempt 6: added two more Any type hints

    @BuzzCutNorman
    BuzzCutNorman committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    d5bd8f9 View commit details
    Browse the repository at this point in the history

  8. mypy revert attempts

    @BuzzCutNorman
    BuzzCutNorman committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    40db24a View commit details
    Browse the repository at this point in the history

  9. mypy attempt: not initalizing just type hinting

    @BuzzCutNorman
    BuzzCutNorman committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    1f68e76 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2023

  1. mypy attempt: add get_add_class and use type[]

    @BuzzCutNorman
    BuzzCutNorman committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    6f3b9c8 View commit details
    Browse the repository at this point in the history

  2. added test_target_base::test_sql_get_sink

    @BuzzCutNorman
    BuzzCutNorman committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    6d8e2bb View commit details
    Browse the repository at this point in the history

  3. added test for add_sqlsink

    @BuzzCutNorman
    BuzzCutNorman committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    76775d3 View commit details
    Browse the repository at this point in the history

  4. updated test_sql_get_sink

    @BuzzCutNorman
    BuzzCutNorman committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    16e96cc View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into 1772-sqltarget-level-connector-instance-shar… 

    …ed-with-sinks
    @edgarrmondragon
    edgarrmondragon authored Jul 26, 2023
    Configuration menu
    Copy the full SHA
    367e487 View commit details
    Browse the repository at this point in the history

  6. Apply suggestions from code review 

    Co-authored-by: Edgar R. M. <edgarrm358@gmail.com>
    @BuzzCutNorman @edgarrmondragon
    BuzzCutNorman and edgarrmondragon authored Jul 26, 2023
    Configuration menu
    Copy the full SHA
    2a1fca7 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2023

  1. Merge branch 'main' into 1772-sqltarget-level-connector-instance-shar… 

    …ed-with-sinks
    @edgarrmondragon
    edgarrmondragon authored Jul 27, 2023
    Configuration menu
    Copy the full SHA
    8d2d9c3 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2023

  1. Merge branch 'main' into 1772-sqltarget-level-connector-instance-shar… 

    …ed-with-sinks
    @edgarrmondragon
    edgarrmondragon authored Jul 28, 2023
    Configuration menu
    Copy the full SHA
    e628032 View commit details
    Browse the repository at this point in the history