fix(mappers): Map record field to a JSON object type
#1885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Codecov Report
@@ Coverage Diff @@
## main #1885 +/- ##
=======================================
Coverage 87.16% 87.16%
=======================================
Files 59 59
Lines 5120 5120
Branches 827 827
=======================================
Hits 4463 4463
Misses 463 463
Partials 194 194
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…ms-maps-gets-incorrectly-mapped-to-a-string-type-in-the-schema
…ms-maps-gets-incorrectly-mapped-to-a-string-type-in-the-schema
…ms-maps-gets-incorrectly-mapped-to-a-string-type-in-the-schema
…ms-maps-gets-incorrectly-mapped-to-a-string-type-in-the-schema
…ms-maps-gets-incorrectly-mapped-to-a-string-type-in-the-schema
…ms-maps-gets-incorrectly-mapped-to-a-string-type-in-the-schema
…ms-maps-gets-incorrectly-mapped-to-a-string-type-in-the-schema
…ms-maps-gets-incorrectly-mapped-to-a-string-type-in-the-schema
…ms-maps-gets-incorrectly-mapped-to-a-string-type-in-the-schema
…ms-maps-gets-incorrectly-mapped-to-a-string-type-in-the-schema
edgarrmondragon
deleted the
1882-bug-a-field-referencing-record-in-streams-maps-gets-incorrectly-mapped-to-a-string-type-in-the-schema
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TBD:
Should the schema for the full record be simply
{"type": "object", "properties": {}}, i.e. fully variant schema, or preserve all the schema information about the record? It currently does the former.RESOLVED: Use the raw record schema
Closes #1882
📚 Documentation preview 📚: https://meltano-sdk--1885.org.readthedocs.build/en/1885/