Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(mappers): Added support for glob patterns in source stream names #1888

Merged
merged 15 commits into from
Apr 11, 2024
Merged

feat(mappers): Added support for glob patterns in source stream names #1888

merged 15 commits into from
Apr 11, 2024

Conversation

DouweM
Copy link
Contributor

@DouweM DouweM commented Aug 1, 2023 •
edited by github-actions bot
Loading

@pnadolny13
Copy link
Contributor

Related to #699 and #1350 and #1883.

@pnadolny13 pnadolny13 mentioned this pull request Aug 3, 2023
Closed
edgarrmondragon
edgarrmondragon reviewed Aug 3, 2023
View reviewed changes
samples/sample_mapper/mapper.py Outdated Show resolved Hide resolved
singer_sdk/mapper.py Outdated Show resolved Hide resolved
tests/core/test_mapper.py Outdated Show resolved Hide resolved
singer_sdk/mapper.py Show resolved Hide resolved
@edgarrmondragon edgarrmondragon changed the title Add support for glob patterns in source stream names feat(mappers): Add support for glob patterns in source stream names Aug 3, 2023
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 31, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #1888 will not alter performance

Comparing DouweM:stream-patterns (4d5c93b) with main (ff1100a)

Summary

✅ 6 untouched benchmarks

@codecov Codecov
Copy link

codecov bot commented Jan 31, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.76%. Comparing base (ff1100a) to head (4d5c93b).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1888   +/-   ##
=======================================
  Coverage   88.76%   88.76%           
=======================================
  Files          54       54           
  Lines        4779     4779           
  Branches      930      930           
=======================================
  Hits         4242     4242           
  Misses        374      374           
  Partials      163      163

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon changed the title feat(mappers): Add support for glob patterns in source stream names feat(mappers): Added support for glob patterns in source stream names Feb 21, 2024
@edgarrmondragon edgarrmondragon marked this pull request as ready for review April 11, 2024 15:13
@edgarrmondragon
Copy link
Collaborator

Tested this with meltano-map-transform and it looks great :)

https://github.com/MeltanoLabs/meltano-map-transform/actions/runs/8650142183/job/23717977927?pr=241

@edgarrmondragon edgarrmondragon added this pull request to the merge queue Apr 11, 2024
Merged via the queue into meltano:main with commit 7eebef9 Apr 11, 2024
30 checks passed
@edgarrmondragon edgarrmondragon mentioned this pull request May 9, 2024
Closed
@edgarrmondragon edgarrmondragon mentioned this pull request Aug 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgarrmondragon edgarrmondragon edgarrmondragon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DouweM @pnadolny13 @edgarrmondragon